Final Changes with Dr. J notes #22
Conversation
# Conflicts: # KJ1124/Thor_Puzzle_assign.c
|
I haven't seen any progress on this. Message me after you push update and are ready for another review. |
|
Ready for final changes review |
|
|
||
| Thor's Movement | ||
| ---------------- | ||
| .. image:: XYgraph.jpg |
There was a problem hiding this comment.
Starting here, indent your comments so they align with your code below.
KJ1124/Thor_Puzzle_assign.c
Outdated
| initial_thor_x++; | ||
| initial_thor_y++; | ||
| } | ||
| /* Based on the compass it can be determined that Thor will travel E (East).The light_x is the position of the light of power and initial_thor_x is Thor's starting position in the X-coordinate plane. The postion of the light of power is is going in the positive direction and it greater than Thor's starting postion so a condition statement is created that if this is the case travel East. |
There was a problem hiding this comment.
Indent (here and following) to align with code.
| */ | ||
| else if (light_y > initial_thor_y) { | ||
| cout << "SW" << endl; | ||
| initial_thor_y++; |
There was a problem hiding this comment.
Why does x not change here?
| } | ||
| } | ||
| } | ||
| // **ending bracket** |
There was a problem hiding this comment.
What about the other directions (NW, S, etc)?
|
These comments still need to be addressed... |
|
Ping...still waiting on this... |
|
I look forward to your updates. Comment here after you push so I know that you're ready for review. |
|
I made the necessary changes I forgot to comment here. Let me know if you cant see it |
|
I can't see any new commits. |
2 participants
No description provided.